Differential D17005

Fix some form layout issues in settings
ClosedPublic
Actions

Authored by chad on Dec 7 2016, 5:14 AM.

Details

Reviewers

epriestley

Commits

rP8bbed7974d62: Fix some form layout issues in settings

Summary

Form inputs with just text or certain selects had extra space. This uses better text centering.

Test Plan

Review forms on all Settings pages, Custom Policy, Herald.

Diff Detail

Repository

rP Phabricator

Branch

form-nudge (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14799
Build 19354: Run Core Tests
Build 19353: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40912.Dec 7 2016, 5:14 AM

chad retitled this revision from to Fix some form layout issues in settings.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptDec 7 2016, 5:14 AM

minor other spacings

By the way, I really like that PHUIInfoView tweak you did a while back. Error messages are far more pleasant now.

This revision is now accepted and ready to land.Dec 7 2016, 8:53 PM

Closed by commit rP8bbed7974d62: Fix some form layout issues in settings (authored by chad, committed by chad). · Explain WhyDec 7 2016, 9:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-form-view.css

5 lines

Diff 40912

View Options

resources/celerity/map.php