Add sidenav back to workboards
ClosedPublic
Actions

Authored by chad on Nov 30 2016, 5:53 PM.

Details

Reviewers

epriestley

Commits

rPeeb80ba96b59: Add sidenav back to workboards

Summary

This is still reasonably functional and useful to people, and we don't have better mechanics to offset the change.

Test Plan

New Workboard, set Workboard color, test mobile, desktop.

Diff Detail

Repository

rP Phabricator

Branch

workboard-side (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14712
Build 19223: Run Core Tests
Build 19222: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40824.Nov 30 2016, 5:53 PM

chad retitled this revision from to Add sidenav back to workboards.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptNov 30 2016, 5:53 PM

epriestley accepted this revision.Nov 30 2016, 5:54 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 30 2016, 5:54 PM

(Maybe put the breadcrumb link back, too? Probably doesn't matter too much and I could see an argument for the new behavior, though.)

Closed by commit rPeeb80ba96b59: Add sidenav back to workboards (authored by chad, committed by chad). · Explain WhyNov 30 2016, 5:56 PM

This revision was automatically updated to reflect the committed changes.

I kinda prefer the link change, but doubt I'd use it.

I don't feel strongly either way, there's a link to the other destination in the sidebar anyway. My only argument for reverting is that it's slightly more consistent in terms of "clicking the name of the project goes to the same place" (e.g., #project tags go to the default page) but I can counterdiff you if I develop stronger feeling at some point.