Page MenuHomePhabricator

Use HTTPS, not HTTP, in install scripts
ClosedPublic

Authored by epriestley on Nov 29 2016, 1:29 PM.
Tags
None
Referenced Files
F15544846: D16958.diff
Sat, Apr 26, 7:20 AM
F15491923: D16958.id40812.diff
Sat, Apr 12, 8:57 AM
F15488213: D16958.id40818.diff
Thu, Apr 10, 8:22 PM
F15481117: D16958.id.diff
Tue, Apr 8, 6:18 PM
F15477615: D16958.diff
Mon, Apr 7, 4:37 PM
F15446631: D16958.id40818.diff
Mar 27 2025, 7:39 PM
F15446630: D16958.id40812.diff
Mar 27 2025, 7:39 PM
F15442525: D16958.id.diff
Mar 26 2025, 11:46 PM
Subscribers
None

Details

Summary

Via HackerOne. A researcher correctly reports that our install scripts use HTTP, not HTTPS, to fetch resources and execute them as root, which is a potentially significant vulnerability.

Instead, use HTTPS.

Test Plan

Verified that these URIs function correctly over HTTPS.

Diff Detail

Repository
rP Phabricator
Branch
https1
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningscripts/install/install_rhel-derivs.sh:70TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 14700
Build 19205: Run Core Tests
Build 19204: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Use HTTPS, not HTTP, in install scripts.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2016, 2:37 PM
This revision was automatically updated to reflect the committed changes.