Ref T3612. Passes in file size and file icon for non-images.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T3612: Lightbox v2
- Commits
- rP80570d668bb3: Use proper file icons in lightbox
Review a PDF and PSD in a lightbox.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- file-lightbox-icon (branched from master)
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 14698 Build 19202: Run Core Tests Build 19201: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 58 ms | PhabricatorLocalTimeTestCase::Unknown Unit Message (" ") EXCEPTION (PhutilMissingSymbolException): Failed to load class or interface 'PhacilityServices': the class or interface 'PhacilityServices' is not defined in the library map for any loaded phutil library.
If you are not a developer, this almost always means that a library is out of date. For example, you may have upgraded `phabricator` without upgrading `libphutil`, or vice versa. It might also mean that you need to restart Apache or PHP-FPM. Make sure all libraries are up to date and all services have been restarted.
| |
| 1 ms | AlmanacNamesTestCase::Unknown Unit Message (" ") 30 assertions passed. | |
| 0 ms | AlmanacServiceTypeTestCase::Unknown Unit Message (" ") 1 assertion passed. | |
| 0 ms | AphrontHTTPSinkTestCase::Unknown Unit Message (" ") 4 assertions passed. | |
| 0 ms | AphrontHTTPSinkTestCase::Unknown Unit Message (" ") 3 assertions passed. | |
| View Full Test Results (1 Failed · 343 Passed) |
Event Timeline
Comment Actions
Add "services/src/" to your "load-libraries" config to clear that test failure, I think?