Page MenuHomePhabricator

Ignore Calendar date edits which just change the internal date timezone without rescheduling it
ClosedPublic

Authored by epriestley on Nov 28 2016, 5:20 PM.
Tags
None
Referenced Files
F13235484: D16955.id40805.diff
Tue, May 21, 5:31 AM
F13227866: D16955.id40808.diff
Mon, May 20, 5:20 AM
F13220071: D16955.diff
Sat, May 18, 11:07 PM
F13209076: D16955.diff
Thu, May 16, 9:37 PM
F13193981: D16955.id40808.diff
Sun, May 12, 8:12 PM
F13191447: D16955.id.diff
Sat, May 11, 9:10 PM
F13182721: D16955.id40805.diff
Fri, May 10, 1:48 AM
Unknown Object (File)
Tue, May 7, 7:01 AM
Subscribers
None

Details

Summary

Ref T11816. Currently, if someone in California creates an event and then someone in New York edits it, we generate a no-op "<user> changed the start time from 3PM to 3PM." transaction.

This is because the internal timezone of the event is changing, but the actual absolute time is not.

Instead, when an edit wouldn't reschedule an event and would only change the internal timezone, ignore the edit.

Test Plan
  • Edited non-all-day events in PST / EST with out making changes (ignored).
  • Edited non-all-day events in PST / EST with changes (changes worked).
  • Performed the same edits with all-day events, which also were ignored and worked, respectively.
  • Pulled events in and out of all-day mode in different timezones, behavior seemeed reasonable.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Ignore Calendar date edits which just change the internal date timezone without rescheduling it.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 28 2016, 6:29 PM
This revision was automatically updated to reflect the committed changes.