Page MenuHomePhabricator

Allow `bin/storage adjust` to adjust table engines
ClosedPublic

Authored by epriestley on Nov 24 2016, 5:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 25, 3:08 PM
Unknown Object (File)
Fri, Jan 17, 4:26 PM
Unknown Object (File)
Sun, Jan 5, 2:03 PM
Unknown Object (File)
Wed, Jan 1, 1:54 AM
Unknown Object (File)
Tue, Dec 31, 7:52 AM
Unknown Object (File)
Dec 22 2024, 1:32 AM
Unknown Object (File)
Dec 20 2024, 6:31 PM
Unknown Object (File)
Dec 6 2024, 4:06 PM
Subscribers
None

Details

Summary

Ref T11741. On recent-enough versions of MySQL, we would prefer to use InnoDB for fulltext indexes instead of MyISAM.

Allow bin/storage adjust to read actual and expected table engines, and apply adjustments as necessary.

We have one existing bad table that uses the wrong engine, metamta_applicationemail. This change corrects that table.

Test Plan
  • Ran bin/storage upgrade.
  • Saw the adjustment phase apply this change properly:
>>>[463] <query> ALTER TABLE `local_metamta`.`metamta_applicationemail` COLLATE = 'utf8mb4_bin', ENGINE = 'InnoDB'

Diff Detail

Repository
rP Phabricator
Branch
search4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14662
Build 19151: Run Core Tests
Build 19150: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Allow `bin/storage adjust` to adjust table engines.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 24 2016, 5:18 PM
This revision was automatically updated to reflect the committed changes.