Page MenuHomePhabricator
Differential D16939

Use PhutilQueryCompiler in Phabricator fulltext search
ClosedPublic
Actions

Authored by epriestley on Nov 24 2016, 4:23 PM.
Tags
None
Referenced Files
F14347808: D16939.id40772.diff
Thu, Dec 19, 3:19 AM
F14347805: D16939.id40782.diff
Thu, Dec 19, 3:19 AM
F14347780: D16939.id.diff
Thu, Dec 19, 3:14 AM
F14347518: D16939.diff
Thu, Dec 19, 3:03 AM
Unknown Object (File)
Tue, Dec 17, 5:19 AM
Unknown Object (File)
Nov 18 2024, 9:51 PM
Unknown Object (File)
Nov 9 2024, 5:37 PM
Unknown Object (File)
Nov 9 2024, 4:58 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10642: Default search boolean logic is mildly inconvenient and not configurable in Amazon RDS
T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud)
Commits
rPa9560479894f: Use PhutilQueryCompiler in Phabricator fulltext search
Summary

Ref T11741. Fixes T10642. Parse and compile user queries with a consistent ruleset, then submit queries to the backend using whatever ruleset MySQL is configured with.

This means that ft_boolean_syntax no longer needs to be configured (we'll just do the right thing in all cases).

This should improve behavior with RDS immediately (T10642), and allow us to improve behavior with InnoDB in the future (T11741).

Test Plan
  • Ran various queries in the UI, saw the expected results.
  • Ran bad queries, got useful errors.
  • Searched threads in Conpherence.

Diff Detail

Repository
rP Phabricator
Branch
search2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14660
Build 19147: Run Core Tests
Build 19146: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40772.Nov 24 2016, 4:23 PM
epriestley retitled this revision from to Use PhutilQueryCompiler in Phabricator fulltext search.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud), T10642: Default search boolean logic is mildly inconvenient and not configurable in Amazon RDS.
epriestley updated this object.Nov 24 2016, 4:25 PM
chad accepted this revision.Nov 24 2016, 4:45 PM
chad edited edge metadata.
chad added inline comments.
src/applications/config/check/PhabricatorMySQLSetupCheck.php
251

imgres.jpg (183×275 px, 23 KB)

This revision is now accepted and ready to land.Nov 24 2016, 4:45 PM
epriestley added a comment.Nov 24 2016, 5:36 PM

Sadly I'm about to add just as much garbage back for the InnoDB options, but it's at least slightly less arcane.

Closed by commit rPa9560479894f: Use PhutilQueryCompiler in Phabricator fulltext search (authored by epriestley, committed by epriestley). · Explain WhyNov 25 2016, 10:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
check/
38 lines
conpherence/
query/
6 lines
search/
controller/
2 lines
fulltextstorage/
11 lines
storage/
document/
16 lines

Diff 40772

View Options

src/applications/config/check/PhabricatorMySQLSetupCheck.php

Loading...
View Options

src/applications/conpherence/query/ConpherenceFulltextQuery.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/applications/search/fulltextstorage/PhabricatorMySQLFulltextStorageEngine.php

Loading...
View Options

src/applications/search/storage/document/PhabricatorSearchDocument.php

Loading...
Phabricator · Built by Phacility