Differential D16930

Clean up another insufficiently-general exception
ClosedPublic
Actions

Authored by epriestley on Nov 23 2016, 6:31 PM.

Details

Reviewers

chad

Maniphest Tasks

T11044: Support partitioning application databases across multiple database hosts

Commits

rPf19924310431: Clean up another insufficiently-general exception

Summary

Ref T11044. This is still catching the older exceptions, which are now more general.

If you loaded the web UI without MySQL running, this meant you got a less-helpful error.

Test Plan

Stopped MySQL, loaded web UI, got a more-helpful error.

Diff Detail

Repository

rP Phabricator

Branch

ex1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14642
Build 19122: Run Core Tests
Build 19121: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40751.Nov 23 2016, 6:31 PM

epriestley retitled this revision from to Clean up another insufficiently-general exception.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11044: Support partitioning application databases across multiple database hosts.

chad accepted this revision.Nov 23 2016, 6:41 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 23 2016, 6:41 PM

Closed by commit rPf19924310431: Clean up another insufficiently-general exception (authored by epriestley, committed by epriestley). · Explain WhyNov 23 2016, 6:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

aphront/

configuration/

AphrontApplicationConfiguration.php

4 lines

applications/

config/

issue/

PhabricatorSetupIssue.php

2 lines

Diff 40751

View Options

src/aphront/configuration/AphrontApplicationConfiguration.php