Page MenuHomePhabricator

Separate "browse ref -> commit" and "commit -> upstream" hardpoints from `arc browse` workflow
ClosedPublic

Authored by epriestley on Nov 23 2016, 5:49 PM.
Tags
None
Referenced Files
F15340826: D16929.id40761.diff
Sun, Mar 9, 4:56 PM
F15340417: D16929.id40750.diff
Sun, Mar 9, 3:09 PM
Unknown Object (File)
Sat, Feb 22, 11:14 AM
Unknown Object (File)
Thu, Feb 20, 3:17 AM
Unknown Object (File)
Feb 6 2025, 8:04 PM
Unknown Object (File)
Jan 28 2025, 2:06 AM
Unknown Object (File)
Jan 20 2025, 11:38 AM
Unknown Object (File)
Jan 20 2025, 11:38 AM
Subscribers
None

Details

Summary

Ref T10895. Currently, the "browse as a commit" code does these lookups, but the code can't be reused.

For T10895, I want to introduce "browse as revision", but it will need to do the same ref lookup. Separate this as a hardpoint so the code can be shared via hardpoint/ref infrastructure.

Test Plan

Ran arc browse master and similar commands.

Diff Detail

Repository
rARC Arcanist
Branch
xp5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14641
Build 19120: Run Core Tests
Build 19119: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Separate "browse ref -> commit" and "commit -> upstream" hardpoints from `arc browse` workflow.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 5:50 PM
This revision was automatically updated to reflect the committed changes.