Page MenuHomePhabricator
Differential D16929

Separate "browse ref -> commit" and "commit -> upstream" hardpoints from `arc browse` workflow
ClosedPublic
Actions

Authored by epriestley on Nov 23 2016, 5:49 PM.
Tags
None
Referenced Files
F15340826: D16929.id40761.diff
Sun, Mar 9, 4:56 PM
F15340417: D16929.id40750.diff
Sun, Mar 9, 3:09 PM
Unknown Object (File)
Sat, Feb 22, 11:14 AM
Unknown Object (File)
Feb 20 2025, 3:17 AM
Unknown Object (File)
Feb 6 2025, 8:04 PM
Unknown Object (File)
Jan 28 2025, 2:06 AM
Unknown Object (File)
Jan 20 2025, 11:38 AM
Unknown Object (File)
Jan 20 2025, 11:38 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`
Commits
rARCd00de495bcf5: Separate "browse ref -> commit" and "commit -> upstream" hardpoints from `arc…
Summary

Ref T10895. Currently, the "browse as a commit" code does these lookups, but the code can't be reused.

For T10895, I want to introduce "browse as revision", but it will need to do the same ref lookup. Separate this as a hardpoint so the code can be shared via hardpoint/ref infrastructure.

Test Plan

Ran arc browse master and similar commands.

Diff Detail

Repository
rARC Arcanist
Branch
xp5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14641
Build 19120: Run Core Tests
Build 19119: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40750.Nov 23 2016, 5:49 PM
epriestley retitled this revision from to Separate "browse ref -> commit" and "commit -> upstream" hardpoints from `arc browse` workflow.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.
chad accepted this revision.Nov 23 2016, 5:50 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 5:50 PM
Closed by commit rARCd00de495bcf5: Separate "browse ref -> commit" and "commit -> upstream" hardpoints from `arc… (authored by epriestley, committed by epriestley). · Explain WhyNov 23 2016, 9:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40750

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/browse/loader/ArcanistBrowseCommitHardpointLoader.php

Loading...
View Options

src/browse/loader/ArcanistBrowseCommitURIHardpointLoader.php

Loading...
View Options

src/browse/ref/ArcanistBrowseRef.php

Loading...
View Options

src/loader/ArcanistCommitUpstreamHardpointLoader.php

Loading...
View Options

src/loader/ArcanistHardpointLoader.php

Loading...
View Options

src/ref/ArcanistCommitRef.php

Loading...
Phabricator · Built by Phacility