Page MenuHomePhabricator
Differential D16920

Prevent media from autoplaying when rendered as a feed story
ClosedPublic
Actions

Authored by epriestley on Nov 22 2016, 10:17 PM.
Tags
None
Referenced Files
F14347995: D16920.diff
Thu, Dec 19, 4:41 AM
F14347764: D16920.diff
Thu, Dec 19, 3:08 AM
F14325752: D16920.id40734.diff
Wed, Dec 18, 2:15 PM
Unknown Object (File)
Tue, Dec 17, 12:56 AM
Unknown Object (File)
Tue, Dec 3, 12:51 PM
Unknown Object (File)
Thu, Nov 28, 4:36 PM
Unknown Object (File)
Tue, Nov 26, 6:43 PM
Unknown Object (File)
Fri, Nov 22, 9:16 AM
View All Files
Subscribers
None
Tokens
"Party Time" token, awarded by epriestley.

Details

Reviewers
chad
Maniphest Tasks
T11845: Media with "autoplay" should possibly not autoplay in news feed
Commits
rP4dadad53ae5d: Prevent media from autoplaying when rendered as a feed story
Summary

Fixes T11845. Users can still embed a text panel on the home page to give it some ambiance.

Test Plan

Wrote an autoplay video as a comment, saw it in feed. Before change: autoplay. After change: no auto play. On task: still autoplay.

Diff Detail

Repository
rP Phabricator
Branch
autoplay1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14626
Build 19097: Run Core Tests
Build 19096: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40734.Nov 22 2016, 10:17 PM
epriestley retitled this revision from to Prevent media from autoplaying when rendered as a feed story.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11845: Media with "autoplay" should possibly not autoplay in news feed.
epriestley added a comment.Nov 22 2016, 10:18 PM

This is a SAD CHANGE because we HATE FUN.

epriestley awarded a token.Nov 22 2016, 10:18 PM
chad edited edge metadata.Nov 22 2016, 10:19 PM

frowncat

chad accepted this revision.Nov 22 2016, 10:19 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 22 2016, 10:19 PM
Closed by commit rP4dadad53ae5d: Prevent media from autoplaying when rendered as a feed story (authored by epriestley, committed by epriestley). · Explain WhyNov 22 2016, 10:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
feed/
story/
2 lines
files/
markup/
6 lines
infrastructure/
markup/
4 lines

Diff 40734

View Options

src/applications/feed/story/PhabricatorFeedStory.php

Loading...
View Options

src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php

Loading...
View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...
Phabricator · Built by Phacility