Page MenuHomePhabricator

Fix a couple of calendar export daterange issues
ClosedPublic

Authored by epriestley on Nov 18 2016, 5:37 PM.
Tags
None
Referenced Files
F13422050: D16898.diff
Mon, Jul 8, 5:37 PM
F13399537: D16898.diff
Thu, Jul 4, 10:27 AM
F13392695: D16898.diff
Tue, Jul 2, 4:53 PM
F13382032: D16898.diff
Sun, Jun 30, 3:40 AM
F13352378: D16898.diff
Sun, Jun 23, 12:37 PM
F13335890: D16898.diff
Wed, Jun 19, 3:41 AM
F13306585: D16898.diff
Sun, Jun 9, 8:22 AM
F13271996: D16898.diff
May 30 2024, 7:13 AM
Subscribers
None

Details

Summary

Ref T11816. In some cases, Calendar would only export a subset of events because the "export" flag was ignored or the "display" parameter applied an improper date range to the query.

  • Make sure the export flag gets processed, even though it isn't a "real" field on the search engine.
  • Clear the "display" parameter to avoid date range windowing coming from the day/month logic.
Test Plan

Exported a "display=month" view, verified future events came with it.

Diff Detail

Repository
rP Phabricator
Branch
icsx1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14568
Build 19008: Run Core Tests
Build 19007: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix a couple of calendar export daterange issues.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 18 2016, 6:01 PM
This revision was automatically updated to reflect the committed changes.