When a field isn't lockable, just freeze the lock status instead of removing any lock
ClosedPublic
Actions

Authored by epriestley on Nov 17 2016, 10:52 PM.

Details

Reviewers

Commits

rPbb6bd8c8d034: (stable) When a field isn't lockable, just freeze the lock status instead of…
rP0033fe666757: When a field isn't lockable, just freeze the lock status instead of removing…

Summary

See downstream issue here: https://phabricator.wikimedia.org/T150992

In at least one case (project milestones) we have a locked, non-lockable field. This means "this is locked, and you can't change the fact that it is locked".

At least for now, preserve this behavior.

Test Plan

Created a new milestone of an existing project. This worked correctly with the patch.

Diff Detail

Repository

rP Phabricator

Branch

milestone1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14561
Build 18996: Run Core Tests
Build 18995: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40671.Nov 17 2016, 10:52 PM

epriestley retitled this revision from to When a field isn't lockable, just freeze the lock status instead of removing any lock.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Nov 17 2016, 10:53 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 17 2016, 10:53 PM

Closed by commit rP0033fe666757: When a field isn't lockable, just freeze the lock status instead of removing… (authored by epriestley, committed by epriestley). · Explain WhyNov 17 2016, 11:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

storage/

PhabricatorEditEngineConfiguration.php

17 lines

Diff 40671

View Options

src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php

When a field isn't lockable, just freeze the lock status instead of removing any lockClosedPublicActions