Page MenuHomePhabricator

Remove sidenav from Workboards
ClosedPublic

Authored by chad on Nov 16 2016, 6:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 12:22 PM
Unknown Object (File)
Wed, Dec 18, 6:01 PM
Unknown Object (File)
Wed, Dec 18, 5:59 PM
Unknown Object (File)
Wed, Dec 18, 2:56 PM
Unknown Object (File)
Wed, Dec 18, 10:07 AM
Unknown Object (File)
Mon, Dec 16, 10:19 PM
Unknown Object (File)
Sat, Dec 14, 8:50 AM
Unknown Object (File)
Sun, Dec 1, 2:06 PM

Details

Summary

Visually, I think these are much cleaner (with colors), and provide more workspace. I also don't really use the sidenav here and if I did, it would be to go back to the project homepage. I think this is overall better. If navigation page to project home is difficult or hard to find, we can maybe make a better header / crumbs bar to reduce that.

Test Plan

New project -> basic new board. Existing project -> color board. Desktop, Mobile, Fullscreen

Diff Detail

Repository
rP Phabricator
Branch
workboard (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14532
Build 18953: Run Core Tests
Build 18952: arc lint + arc unit

Event Timeline

chad retitled this revision from to Remove sidenav from Workboards.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
  • always return profile uri
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/project/controller/PhabricatorProjectController.php
122 ↗(On Diff #40645)

Add a getProfileURI() to PhabricatorProject instead?

(Avoid calling methods inside strings; this pathway leads to madness.)

This revision is now accepted and ready to land.Nov 17 2016, 12:34 AM
This revision was automatically updated to reflect the committed changes.

We use the workboard as the default page for our projects and as such were using the side-menu for quick navigation to various items (Phriction page link, specific tag filters for the workboard for example). Is there any way this change could become optional using the settings?

We also used links in the sidebar to quickly filter by team/tag.

Like so:
/project/board/5/query/HIpzLiC1CLjg/
/project/board/5/query/XKElxaLcdR.V/

Can this please be made an option? Or suggestions for alternate ways to accomplish this would be welcome.