Page MenuHomePhabricator
Differential D16880

Use the same date rendering display logic for both tooltips and subheaders
ClosedPublic
Actions

Authored by epriestley on Nov 16 2016, 3:37 PM.
Tags
None
Referenced Files
F14053676: D16880.diff
Fri, Nov 15, 6:08 PM
F14042315: D16880.diff
Tue, Nov 12, 2:27 AM
F14032053: D16880.id40641.diff
Sat, Nov 9, 12:39 PM
F14032052: D16880.id40637.diff
Sat, Nov 9, 12:39 PM
F14032051: D16880.id.diff
Sat, Nov 9, 12:39 PM
F14025894: D16880.diff
Thu, Nov 7, 9:02 PM
F14019782: D16880.diff
Tue, Nov 5, 11:38 PM
F13974279: D16880.diff
Oct 18 2024, 4:53 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11816: Calendar: Feedback and Suggestions
Commits
rPf33b5c30ebe0: Use the same date rendering display logic for both tooltips and subheaders
Summary

Ref T11816. This could be a little cleaner, but we currently have two copies of the logic. Get them using the same code. Once that's actually working I can go make the code a little prettier.

Test Plan

Viewed Calendar month view tooltips, saw the same values as subheaders.

Diff Detail

Repository
rP Phabricator
Branch
cal2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14525
Build 18944: Run Core Tests
Build 18943: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40637.Nov 16 2016, 3:37 PM
epriestley retitled this revision from to Use the same date rendering display logic for both tooltips and subheaders.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11816: Calendar: Feedback and Suggestions.
epriestley mentioned this in T11816: Calendar: Feedback and Suggestions.Nov 16 2016, 3:53 PM
chad accepted this revision.Nov 16 2016, 4:36 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 16 2016, 4:36 PM
Closed by commit rPf33b5c30ebe0: Use the same date rendering display logic for both tooltips and subheaders (authored by epriestley, committed by epriestley). · Explain WhyNov 16 2016, 4:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
query/
2 lines
view/
10 lines
people/
controller/
1 line
view/
phui/
calendar/
50 lines

Diff 40637

View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
View Options

src/applications/calendar/view/AphrontCalendarEventView.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarListView.php

Loading...
Phabricator · Built by Phacility