Page MenuHomePhabricator

Use the same date rendering display logic for both tooltips and subheaders
ClosedPublic

Authored by epriestley on Nov 16 2016, 3:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 5:41 AM
Unknown Object (File)
Sat, Dec 7, 1:20 AM
Unknown Object (File)
Fri, Nov 22, 11:53 PM
Unknown Object (File)
Wed, Nov 20, 6:42 PM
Unknown Object (File)
Nov 15 2024, 6:08 PM
Unknown Object (File)
Nov 12 2024, 2:27 AM
Unknown Object (File)
Nov 9 2024, 12:39 PM
Unknown Object (File)
Nov 9 2024, 12:39 PM
Subscribers
None

Details

Summary

Ref T11816. This could be a little cleaner, but we currently have two copies of the logic. Get them using the same code. Once that's actually working I can go make the code a little prettier.

Test Plan

Viewed Calendar month view tooltips, saw the same values as subheaders.

Diff Detail

Repository
rP Phabricator
Branch
cal2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14525
Build 18944: Run Core Tests
Build 18943: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Use the same date rendering display logic for both tooltips and subheaders.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 16 2016, 4:36 PM
This revision was automatically updated to reflect the committed changes.