Clean up a little more Calendar display logic
ClosedPublic
Actions

Authored by epriestley on Nov 15 2016, 9:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 9, 2:49 AM

	Unknown Object (File)
	Sun, Feb 9, 2:49 AM

	Unknown Object (File)
	Sun, Feb 9, 2:49 AM

	Unknown Object (File)
	Mon, Feb 3, 11:42 PM

	Unknown Object (File)
	Thu, Jan 30, 1:35 PM

	Unknown Object (File)
	Tue, Jan 28, 6:04 PM

	Unknown Object (File)
	Fri, Jan 24, 5:50 PM

	Unknown Object (File)
	Fri, Jan 24, 5:50 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

rP6e5565b3ff6d: Clean up a little more Calendar display logic

Summary

Uh, non-all-day-events said 1:30 - 2:29 PM, which is real silly.

Test Plan

Looked at a non-all-day-event.

Diff Detail

Repository

rP Phabricator

Branch

cal4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14516
Build 18930: Run Core Tests
Build 18929: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40627.Nov 15 2016, 9:50 PM

epriestley retitled this revision from to Clean up a little more Calendar display logic.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Nov 15 2016, 9:58 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 15 2016, 9:58 PM

Closed by commit rP6e5565b3ff6d: Clean up a little more Calendar display logic (authored by epriestley, committed by epriestley). · Explain WhyNov 15 2016, 10:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

storage/

PhabricatorCalendarEvent.php

4 lines

Diff 40627

View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Clean up a little more Calendar display logicClosedPublicActions