Page MenuHomePhabricator
Differential D16867

Fix a bug on Calendar event day views for all day events in certain timezones
ClosedPublic
Actions

Authored by epriestley on Nov 15 2016, 6:19 PM.
Tags
None
Referenced Files
F14052463: D16867.diff
Fri, Nov 15, 9:03 AM
F14038685: D16867.diff
Mon, Nov 11, 1:18 AM
F14024304: D16867.diff
Thu, Nov 7, 8:04 AM
F14006801: D16867.id40611.diff
Mon, Oct 28, 6:04 PM
F13998384: D16867.id.diff
Thu, Oct 24, 9:15 AM
F13994502: D16867.id.diff
Wed, Oct 23, 6:36 AM
F13986244: D16867.diff
Mon, Oct 21, 1:31 AM
F13979992: D16867.id.diff
Oct 19 2024, 7:47 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11816: Calendar: Feedback and Suggestions
Commits
rP6464934cd6be: Fix a bug on Calendar event day views for all day events in certain timezones
Summary

Ref T11816. This logic was correct, we just did all the work and then mostly threw away the results. This worked correctly anyway in some timezones.

Instead, actually use $min_date and $max_date.

Test Plan

In "America/Toronto" with server in a more-western timezone, viewed a "Nov 11 - Nov 12" all-day event, saw those dates.

Diff Detail

Repository
rP Phabricator
Branch
allday1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14500
Build 18907: Run Core Tests
Build 18906: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40611.Nov 15 2016, 6:19 PM
epriestley retitled this revision from to Fix a bug on Calendar event day views for all day events in certain timezones.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11816: Calendar: Feedback and Suggestions.
chad accepted this revision.Nov 15 2016, 6:23 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 15 2016, 6:23 PM
Closed by commit rP6464934cd6be: Fix a bug on Calendar event day views for all day events in certain timezones (authored by epriestley, committed by epriestley). · Explain WhyNov 15 2016, 7:10 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T11816: Calendar: Feedback and Suggestions.Nov 15 2016, 7:46 PM

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
storage/
10 lines

Diff 40611

View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
Phabricator · Built by Phacility