Page MenuHomePhabricator

Fix a bug on Calendar event day views for all day events in certain timezones
ClosedPublic

Authored by epriestley on Nov 15 2016, 6:19 PM.
Tags
None
Referenced Files
F14347898: D16867.id40611.diff
Thu, Dec 19, 3:54 AM
F14313427: D16867.id40615.diff
Wed, Dec 18, 4:12 AM
Unknown Object (File)
Wed, Nov 27, 4:09 AM
Unknown Object (File)
Tue, Nov 19, 3:06 PM
Unknown Object (File)
Nov 15 2024, 9:03 AM
Unknown Object (File)
Nov 11 2024, 1:18 AM
Unknown Object (File)
Nov 7 2024, 8:04 AM
Unknown Object (File)
Oct 28 2024, 6:04 PM
Subscribers
None

Details

Summary

Ref T11816. This logic was correct, we just did all the work and then mostly threw away the results. This worked correctly anyway in some timezones.

Instead, actually use $min_date and $max_date.

Test Plan

In "America/Toronto" with server in a more-western timezone, viewed a "Nov 11 - Nov 12" all-day event, saw those dates.

Diff Detail

Repository
rP Phabricator
Branch
allday1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14500
Build 18907: Run Core Tests
Build 18906: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix a bug on Calendar event day views for all day events in certain timezones.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 15 2016, 6:23 PM
This revision was automatically updated to reflect the committed changes.