Differential D16866

On tablet/mobile, open the datepicker control in the center of the screen and mask the background
ClosedPublic
Actions

Authored by epriestley on Nov 15 2016, 6:11 PM.

Tags

None

Referenced Files

	F14404841: D16866.diff
	Mon, Dec 23, 6:15 AM

	Unknown Object (File)
	Mon, Dec 16, 5:49 PM

	Unknown Object (File)
	Thu, Dec 12, 7:54 AM

	Unknown Object (File)
	Sun, Dec 8, 12:20 PM

	Unknown Object (File)
	Sat, Dec 7, 9:37 AM

	Unknown Object (File)
	Sat, Dec 7, 12:03 AM

	Unknown Object (File)
	Wed, Dec 4, 2:37 PM

	Unknown Object (File)
	Tue, Dec 3, 12:47 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T11816: Calendar: Feedback and Suggestions

Commits

rPf91269a4a8a6: On tablet/mobile, open the datepicker control in the center of the screen and…

Summary

Ref T11816. We currently try to expand the picker control from the little calendar icon. This works alright on desktop, but not great on tablet/mobile.

On tablet/mobile, center the control on screen instead. Also, mask the background since it can get a bit busy because we can't really control what's under the control anymore.

Finally, move the little popup thing around if the user resizes the window.

Test Plan

Screen Shot 2016-11-15 at 10.09.40 AM.png (727×616 px, 78 KB)

Diff Detail

Repository

Branch

dpick1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14499
Build 18905: Run Core Tests
Build 18904: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40610.Nov 15 2016, 6:11 PM

epriestley retitled this revision from to On tablet/mobile, open the datepicker control in the center of the screen and mask the background.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11816: Calendar: Feedback and Suggestions.

Herald edited edge metadata. · View Herald TranscriptNov 15 2016, 6:11 PM

chad accepted this revision.Nov 15 2016, 6:14 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 15 2016, 6:14 PM

Closed by commit rPf91269a4a8a6: On tablet/mobile, open the datepicker control in the center of the screen and… (authored by epriestley, committed by epriestley). · Explain WhyNov 15 2016, 6:19 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T11816: Calendar: Feedback and Suggestions.Nov 15 2016, 7:46 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

28 lines

webroot/

rsrc/

css/

aphront/

dialog-view.css

9 lines

phui/

phui-form-view.css

6 lines

js/

core/

behavior-fancy-datepicker.js

46 lines

Diff 40610

resources/celerity/map.php

Loading...

webroot/rsrc/css/aphront/dialog-view.css

Loading...

webroot/rsrc/css/phui/phui-form-view.css

Loading...

webroot/rsrc/js/core/behavior-fancy-datepicker.js

Loading...