Differential D16865

When importing ICS files, map "W. Europe Standard Time" to "Europe/Berlin"
ClosedPublic
Actions

Authored by epriestley on Nov 15 2016, 5:55 PM.

Details

Reviewers

chad

Maniphest Tasks

T11816: Calendar: Feedback and Suggestions

Commits

rPHU57ee1d81e7aa: When importing ICS files, map "W. Europe Standard Time" to "Europe/Berlin"

Summary

Ref T11816. See that task for discussion. If we get a few more of these I'll try to mangle in a big list of Windows timezone names.

Test Plan

Looked at timezone offsets in VTIMEZONE, matched them up to CET/CEST offsets.

Diff Detail

Repository

rPHU libphutil

Branch

tz1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14498
Build 18903: Run Core Tests
Build 18902: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40609.Nov 15 2016, 5:55 PM

epriestley retitled this revision from to When importing ICS files, map "W. Europe Standard Time" to "Europe/Berlin".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11816: Calendar: Feedback and Suggestions.

chad accepted this revision.Nov 15 2016, 5:55 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 15 2016, 5:55 PM

Closed by commit rPHU57ee1d81e7aa: When importing ICS files, map "W. Europe Standard Time" to "Europe/Berlin" (authored by epriestley, committed by epriestley). · Explain WhyNov 15 2016, 6:20 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T11816: Calendar: Feedback and Suggestions.Nov 15 2016, 7:46 PM

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

ics/

PhutilICSParser.php

5 lines

Diff 40609

View Options

src/parser/calendar/ics/PhutilICSParser.php

When importing ICS files, map "W. Europe Standard Time" to "Europe/Berlin"ClosedPublicActions