Paths

Table of Contentst

Differential D16864

Make Passphrase "token" credentials accessible via the API
ClosedPublic
Actions

Authored by epriestley on Nov 15 2016, 5:09 PM.

Details

Reviewers

chad

Maniphest Tasks

T11867: Passphrase Conduit API does not specify secret for token credential type

Commits

rP885805f34067: Make Passphrase "token" credentials accessible via the API

Summary

Fixes T11867. This should really be on the CredentialType itself, but just punt that for now until the API endpoint gets updated. We'll need the actual code here anyway in some form.

Test Plan

Screen Shot 2016-11-15 at 9.07.35 AM.png (252×534 px, 35 KB)

Diff Detail

Repository

rP Phabricator

Branch

phrase1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14494
Build 18898: Run Core Tests
Build 18897: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40604.Nov 15 2016, 5:09 PM

epriestley retitled this revision from to Make Passphrase "token" credentials accessible via the API.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11867: Passphrase Conduit API does not specify secret for token credential type.

chad accepted this revision.Nov 15 2016, 5:12 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 15 2016, 5:12 PM

Closed by commit rP885805f34067: Make Passphrase "token" credentials accessible via the API (authored by epriestley, committed by epriestley). · Explain WhyNov 15 2016, 5:12 PM

This revision was automatically updated to reflect the committed changes.

Hi @epriestley, the T11867 description (but not the title) also mentioned the note credential type. I don't know if you prefer a new ticket, so just in case, here is my comment...

case PassphraseNoteCredentialType::CREDENTIAL_TYPE:
  if ($secret !== null) {
    $material['note'] = $secret;
  }
  break;

Revision Contents
Changeset List

Path

Size

src/

applications/

passphrase/

conduit/

PassphraseQueryConduitAPIMethod.php

11 lines

Diff 40604

View Options

src/applications/passphrase/conduit/PassphraseQueryConduitAPIMethod.php

Make Passphrase "token" credentials accessible via the APIClosedPublicActions