Page MenuHomePhabricator

Add a bunch of Phacility-specific code to the upstream, thinly veiled as generic code
ClosedPublic

Authored by epriestley on Nov 15 2016, 4:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 16, 10:43 AM
Unknown Object (File)
Fri, Jan 10, 6:05 PM
Unknown Object (File)
Fri, Jan 10, 5:53 PM
Unknown Object (File)
Fri, Jan 3, 4:31 AM
Unknown Object (File)
Wed, Jan 1, 4:37 PM
Unknown Object (File)
Wed, Jan 1, 4:37 PM
Unknown Object (File)
Wed, Jan 1, 4:37 PM
Unknown Object (File)
Sun, Dec 29, 11:39 AM
Subscribers
None

Details

Summary

Ref T9304. This adds a "GuidanceEngine" which can generate "Guidance".

In practice, this lets third-party code (rSERVICES) remove and replace instructions in the UI, which is basically only usefulf or us to tell users to go read the documentation in the Phacility cluster.

The next diff tailors the help on the "Auth Providers" and "Create New User" pages to say "PHACILITY PHACILITY PHACILITY PHACILITY".

Test Plan

Browed to "Auth Providers" and "Create New User" on instanced and non-instanced installs, saw appropriate guidance.

Diff Detail

Repository
rP Phabricator
Branch
guide1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14491
Build 18893: Run Core Tests
Build 18892: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Add a bunch of Phacility-specific code to the upstream, thinly veiled as generic code.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 15 2016, 5:05 PM
This revision was automatically updated to reflect the committed changes.