Page MenuHomePhabricator
Differential D16850

Update PHUIInfoView
ClosedPublic
Actions

Authored by chad on Nov 13 2016, 5:00 AM.
Tags
None
Referenced Files
F14487215: D16850.diff
Tue, Dec 31, 10:57 PM
Unknown Object (File)
Tue, Dec 17, 6:32 PM
Unknown Object (File)
Mon, Dec 16, 6:02 PM
Unknown Object (File)
Fri, Dec 13, 9:29 PM
Unknown Object (File)
Nov 30 2024, 2:03 PM
Unknown Object (File)
Nov 26 2024, 2:13 AM
Unknown Object (File)
Nov 25 2024, 2:20 PM
Unknown Object (File)
Nov 20 2024, 11:22 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP037793ab607a: Update PHUIInfoView
Summary

Just some minor UI tweaks. Make AphrontTagView, add Icons, whiten background.

Test Plan

Legalpad, Settings, Auth, UIExamples, Differential... desktop, mobile.

Diff Detail

Repository
rP Phabricator
Branch
info-view (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14469
Build 18861: Run Core Tests
Build 18860: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40577.Nov 13 2016, 5:00 AM
chad retitled this revision from to Update PHUIInfoView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 13 2016, 5:00 AM
epriestley accepted this revision.Nov 13 2016, 5:29 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 13 2016, 5:29 AM
chad added a comment.Nov 13 2016, 5:30 AM

I'm sure there's some edge cases I might have missed in testing. Like Harbordockmaster.

Closed by commit rP037793ab607a: Update PHUIInfoView (authored by chad, committed by chad). · Explain WhyNov 13 2016, 5:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
2 lines
view/
form/
105 lines
webroot/
rsrc/
css/
phui/
2 lines
80 lines

Diff 40577

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/view/form/PHUIInfoView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-document-pro.css

Loading...
View Options

webroot/rsrc/css/phui/phui-info-view.css

Loading...
Phabricator · Built by Phacility