Page MenuHomePhabricator
Differential D16829

Use "book" as the "Help" icon in the Remarkup toolbar
ClosedPublic
Actions

Authored by epriestley on Nov 8 2016, 11:15 PM.
Tags
None
Referenced Files
F14340083: D16829.diff
Wed, Dec 18, 6:59 PM
Unknown Object (File)
Sat, Dec 14, 3:45 PM
Unknown Object (File)
Nov 11 2024, 4:27 AM
Unknown Object (File)
Nov 3 2024, 1:12 AM
Unknown Object (File)
Oct 19 2024, 4:10 PM
Unknown Object (File)
Oct 17 2024, 1:30 AM
Unknown Object (File)
Sep 15 2024, 4:57 PM
Unknown Object (File)
Sep 13 2024, 5:10 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
rP1747b4d31854: Use "book" as the "Help" icon in the Remarkup toolbar
Summary

See D16811. I missed this while grepping because the other icon has two aliases (life-buoy, life-ring) and we were using one of each.

Test Plan

Screen Shot 2016-11-08 at 3.14.59 PM.png (119×236 px, 5 KB)

Diff Detail

Repository
rP Phabricator
Branch
book1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14415
Build 18780: Run Core Tests
Build 18779: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40525.Nov 8 2016, 11:15 PM
epriestley retitled this revision from to Use "book" as the "Help" icon in the Remarkup toolbar.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Nov 8 2016, 11:23 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2016, 11:23 PM
Closed by commit rP1747b4d31854: Use "book" as the "Help" icon in the Remarkup toolbar (authored by epriestley, committed by epriestley). · Explain WhyNov 8 2016, 11:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
form/
control/
2 lines

Diff 40525

View Options

src/view/form/control/PhabricatorRemarkupControl.php

Loading...
Phabricator · Built by Phacility