Paths

Table of Contentst

Differential D16808

Fix some issues with Phabricator i18n string extraction
ClosedPublic
Actions

Authored by epriestley on Nov 6 2016, 6:48 PM.

Details

Reviewers

chad

Maniphest Tasks

T5267: Localize Phabricator

Commits

rP960c0be6898c: Fix some issues with Phabricator i18n string extraction

Summary

Ref T5267. Fix one minor bug (paths were not being resolved properly) and one minor string issue (missing %d in a string).

Test Plan

Extracted strings, got a cleaner result.

Diff Detail

Repository

rP Phabricator

Branch

i18n2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14369
Build 18710: Run Core Tests
Build 18709: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40477.Nov 6 2016, 6:48 PM

epriestley retitled this revision from to Fix some issues with Phabricator i18n string extraction.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T5267: Localize Phabricator.

chad accepted this revision.Nov 6 2016, 6:49 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 6 2016, 6:49 PM

Closed by commit rP960c0be6898c: Fix some issues with Phabricator i18n string extraction (authored by epriestley, committed by epriestley). · Explain WhyNov 6 2016, 7:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

daemon/

workers/

storage/

PhabricatorWorkerActiveTask.php

2 lines

internationalization/

management/

PhabricatorInternationalizationManagementExtractWorkflow.php

2 lines

Diff 40477

View Options

src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php