Differential D16803

Fix an issue with editing application default policies in Calendar
ClosedPublic
Actions

Authored by epriestley on Nov 4 2016, 11:40 PM.

Details

Reviewers

chad

Maniphest Tasks

T11816: Calendar: Feedback and Suggestions

Commits

rP90fb8a15162f: Fix an issue with editing application default policies in Calendar

Summary

Ref T11816. We're running this code on empty events which haven't been initialized and don't have a source attached -- just use a more explanatory check which doesn't need anything attached.

Test Plan

Edited default Calendar policies.

Diff Detail

Repository

rP Phabricator

Branch

calpol1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14356
Build 18692: Run Core Tests
Build 18691: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40467.Nov 4 2016, 11:40 PM

epriestley retitled this revision from to Fix an issue with editing application default policies in Calendar.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11816: Calendar: Feedback and Suggestions.

chad accepted this revision.Nov 4 2016, 11:43 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 4 2016, 11:43 PM

epriestley mentioned this in T11816: Calendar: Feedback and Suggestions.Nov 4 2016, 11:54 PM

Closed by commit rP90fb8a15162f: Fix an issue with editing application default policies in Calendar (authored by epriestley, committed by epriestley). · Explain WhyNov 4 2016, 11:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

storage/

PhabricatorCalendarEvent.php

6 lines

Diff 40467

View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Fix an issue with editing application default policies in CalendarClosedPublicActions