Page MenuHomePhabricator

Add a skeleton for Calendar notifications
ClosedPublic

Authored by epriestley on Nov 1 2016, 4:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 9:34 AM
Unknown Object (File)
Tue, Dec 10, 6:41 PM
Unknown Object (File)
Mon, Dec 9, 5:59 AM
Unknown Object (File)
Thu, Nov 28, 7:41 AM
Unknown Object (File)
Thu, Nov 28, 4:36 AM
Unknown Object (File)
Nov 18 2024, 8:40 AM
Unknown Object (File)
Nov 13 2024, 5:32 PM
Unknown Object (File)
Nov 10 2024, 7:17 AM
Subscribers
None

Details

Summary

Ref T7931. I'm going to do this separate from existing infrastructure because:

  • events start at different times for different users;
  • I like the idea of being able to batch stuff (send one email about several upcoming events);
  • triggering on ghost/recurring events is a real complicated mess.

This puts a skeleton in place that finds all the events we need to notify about and writes some silly example bodies to stdout, marking that we notified users so they don't get notified again.

Test Plan

Ran bin/calendar notify, got a "great" notification in the command output.

Screen Shot 2016-10-31 at 6.13.41 PM.png (109×341 px, 11 KB)

Diff Detail

Repository
rP Phabricator
Branch
calendar10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14311
Build 18622: Run Core Tests
Build 18621: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Add a skeleton for Calendar notifications.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 1 2016, 5:34 PM
This revision was automatically updated to reflect the committed changes.