Page MenuHomePhabricator

Record a "series parent PHID" on Calendar events that retains relationships after forks
ClosedPublic

Authored by epriestley on Oct 31 2016, 8:54 PM.
Tags
None
Referenced Files
F13235220: D16780.diff
Tue, May 21, 4:28 AM
F13230054: D16780.id40418.diff
Mon, May 20, 8:22 PM
F13218867: D16780.id40408.diff
Sat, May 18, 1:20 PM
F13189942: D16780.diff
Sat, May 11, 6:36 AM
Unknown Object (File)
Tue, May 7, 10:16 AM
Unknown Object (File)
Fri, May 3, 10:38 AM
Unknown Object (File)
Fri, May 3, 7:31 AM
Unknown Object (File)
Thu, Apr 25, 3:57 AM
Subscribers
None

Details

Summary

When you edit "X and all future events", X becomes the new parent of an event series.

Currently, it loses its relationship to its original parent. Instead, retain that relationship -- it's separate from the normal "parent", but we can use it to make the UI more clear or tweak behaviors later.

This mostly just keeps us from losing/destroying data that we might need/want later.

Test Plan
  • Ran migrations.
  • Cancelled "X and all future events", saw sensible-appearing beahvior in the database for "seriesParentPHID".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Record a "series parent PHID" on Calendar events that retains relationships after forks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 31 2016, 9:03 PM
This revision was automatically updated to reflect the committed changes.