Page MenuHomePhabricator

Record a "series parent PHID" on Calendar events that retains relationships after forks
ClosedPublic

Authored by epriestley on Oct 31 2016, 8:54 PM.
Tags
None
Referenced Files
F14060016: D16780.diff
Sun, Nov 17, 11:01 PM
F14031587: D16780.id40408.diff
Sat, Nov 9, 11:29 AM
F14025914: D16780.diff
Thu, Nov 7, 9:22 PM
F13985113: D16780.id40418.diff
Sun, Oct 20, 6:04 PM
F13971530: D16780.diff
Oct 17 2024, 1:51 PM
F13969619: D16780.id40408.diff
Oct 17 2024, 3:25 AM
Unknown Object (File)
Oct 2 2024, 6:56 AM
Unknown Object (File)
Aug 30 2024, 5:42 AM
Subscribers
None

Details

Summary

When you edit "X and all future events", X becomes the new parent of an event series.

Currently, it loses its relationship to its original parent. Instead, retain that relationship -- it's separate from the normal "parent", but we can use it to make the UI more clear or tweak behaviors later.

This mostly just keeps us from losing/destroying data that we might need/want later.

Test Plan
  • Ran migrations.
  • Cancelled "X and all future events", saw sensible-appearing beahvior in the database for "seriesParentPHID".

Diff Detail

Repository
rP Phabricator
Branch
calendar7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14298
Build 18605: Run Core Tests
Build 18604: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Record a "series parent PHID" on Calendar events that retains relationships after forks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 31 2016, 9:03 PM
This revision was automatically updated to reflect the committed changes.