Page MenuHomePhabricator
Differential D16779

Remove "isCancelledEvent()" wrapper on Calendar Events
ClosedPublic
Actions

Authored by epriestley on Oct 31 2016, 8:43 PM.
Tags
None
Referenced Files
F15417468: D16779.id40407.diff
Thu, Mar 20, 5:11 PM
F15343425: D16779.diff
Sun, Mar 9, 10:52 PM
Unknown Object (File)
Feb 26 2025, 10:53 AM
Unknown Object (File)
Feb 9 2025, 2:42 AM
Unknown Object (File)
Feb 9 2025, 2:42 AM
Unknown Object (File)
Feb 9 2025, 2:42 AM
Unknown Object (File)
Feb 9 2025, 2:42 AM
Unknown Object (File)
Feb 2 2025, 1:08 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11804: Straighten out canceling and editing instanced events in Calendar
Commits
rPf44a9a4e4896: Remove "isCancelledEvent()" wrapper on Calendar Events
Summary

Ref T11804. The field now reads the correct value directly and we don't need this wrapper.

Test Plan

Poked around Calendar without explosions.

Diff Detail

Repository
rP Phabricator
Branch
calendar6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14297
Build 18603: Run Core Tests
Build 18602: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40407.Oct 31 2016, 8:43 PM
epriestley retitled this revision from to Remove "isCancelledEvent()" wrappe on Calendar Events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11804: Straighten out canceling and editing instanced events in Calendar.
epriestley added a comment.Oct 31 2016, 9:21 PM

A wrappe is a special kind of frappe.

epriestley retitled this revision from Remove "isCancelledEvent()" wrappe on Calendar Events to Remove "isCancelledEvent()" wrapper on Calendar Events.Oct 31 2016, 9:21 PM
chad accepted this revision.Oct 31 2016, 9:45 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 31 2016, 9:45 PM
Closed by commit rPf44a9a4e4896: Remove "isCancelledEvent()" wrapper on Calendar Events (authored by epriestley, committed by epriestley). · Explain WhyOct 31 2016, 10:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40407

View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
View Options

src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
Phabricator · Built by Phacility