Page MenuHomePhabricator
Differential D16765

Use "book" instead of "life ring" icon for global help menu
ClosedPublic
Actions

Authored by epriestley on Oct 28 2016, 9:04 PM.
Tags
None
Referenced Files
F13807835: D16765.diff
Mon, Sep 16, 6:15 PM
Unknown Object (File)
Mon, Sep 2, 5:28 AM
Unknown Object (File)
Wed, Aug 28, 9:27 PM
Unknown Object (File)
Sun, Aug 25, 4:13 PM
Unknown Object (File)
Sun, Aug 25, 2:09 PM
Unknown Object (File)
Tue, Aug 20, 3:16 PM
Unknown Object (File)
Aug 16 2024, 9:16 PM
Unknown Object (File)
Aug 8 2024, 12:48 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
rPa792faf78d82: Use "book" instead of "life ring" icon for global help menu
Summary

This is more consistent with the icon we use for documentation elsewhere.

Test Plan

Looked at the icon, had an easier time guessing it meant "documentation".

Diff Detail

Repository
rP Phabricator
Branch
chelp1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14264
Build 18552: Run Core Tests
Build 18551: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40374.Oct 28 2016, 9:04 PM
epriestley retitled this revision from to Use "book" instead of "life ring" icon for global help menu.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Oct 28 2016, 9:06 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 28 2016, 9:06 PM
Closed by commit rPa792faf78d82: Use "book" instead of "life ring" icon for global help menu (authored by epriestley, committed by epriestley). · Explain WhyOct 28 2016, 9:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
help/
extension/
2 lines

Diff 40374

View Options

src/applications/help/extension/PhabricatorHelpMainMenuBarExtension.php

Loading...
Phabricator · Built by Phacility