Page MenuHomePhabricator
Differential D16754

Suggest better start/end datetimes for Calendar events
ClosedPublic
Actions

Authored by epriestley on Oct 26 2016, 7:52 PM.
Tags
None
Referenced Files
F14052461: D16754.diff
Fri, Nov 15, 9:03 AM
F14048321: D16754.id.diff
Thu, Nov 14, 7:28 AM
F14048272: D16754.id.diff
Thu, Nov 14, 7:18 AM
F14038046: D16754.diff
Sun, Nov 10, 9:10 PM
F14024266: D16754.diff
Thu, Nov 7, 7:40 AM
F14018169: D16754.diff
Tue, Nov 5, 5:37 AM
F14008634: D16754.id40354.diff
Wed, Oct 30, 2:44 AM
F13998179: D16754.id40352.diff
Thu, Oct 24, 7:59 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11638: "Create Event" from day view does not default to visible day
Commits
rP4c3f09a6a660: Suggest better start/end datetimes for Calendar events
Summary

Fixes T11638.

  • Fix a regression: I broke this "round to the nearest hour" code a while ago while fiddling with datetimes.
  • Improve a beahvior: from the day view, make the menu-bar "Create Event" button default to creating an event on the day you were viewing.
Test Plan

Created events from month and day views, got nice round numbers and proper day suggestions.

Diff Detail

Repository
rP Phabricator
Branch
cimport3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14241
Build 18519: Run Core Tests
Build 18518: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40352.Oct 26 2016, 7:52 PM
epriestley retitled this revision from to Suggest better start/end datetimes for Calendar events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11638: "Create Event" from day view does not default to visible day.
chad accepted this revision.Oct 26 2016, 8:09 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 26 2016, 8:09 PM
Closed by commit rP4c3f09a6a660: Suggest better start/end datetimes for Calendar events (authored by epriestley, committed by epriestley). · Explain WhyOct 26 2016, 8:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
controller/
37 lines
storage/
33 lines
transactions/
editengine/
14 lines

Diff 40352

View Options

src/applications/calendar/controller/PhabricatorCalendarEventListController.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
Phabricator · Built by Phacility