Differential D16753

Don't allow "Start Time" / "End Time" in Calendar event forms to be locked or have defaults assigned
ClosedPublic
Actions

Authored by epriestley on Oct 26 2016, 7:38 PM.

Details

Reviewers

chad

Maniphest Tasks

T11733: Calendar custom forms with modified start date / end date defaults don't work properly

Commits

rP7cb44bcee6bf: Don't allow "Start Time" / "End Time" in Calendar event forms to be locked or…

Summary

Fixes T11733. This fixes the issue by working around it, but it isn't useful to set these fields to a default value anyway.

Test Plan

Created a default Calendar form, set some other defaults, created an event, stuff no longer exploded.

Diff Detail

Repository

rP Phabricator

Branch

cimport2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14240
Build 18517: Run Core Tests
Build 18516: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40351.Oct 26 2016, 7:38 PM

epriestley retitled this revision from to Don't allow "Start Time" / "End Time" in Calendar event forms to be locked or have defaults assigned.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11733: Calendar custom forms with modified start date / end date defaults don't work properly.

chad accepted this revision.Oct 26 2016, 7:46 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 26 2016, 7:46 PM

Closed by commit rP7cb44bcee6bf: Don't allow "Start Time" / "End Time" in Calendar event forms to be locked or… (authored by epriestley, committed by epriestley). · Explain WhyOct 26 2016, 8:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

editor/

PhabricatorCalendarEventEditEngine.php

6 lines

transactions/

storage/

PhabricatorEditEngineConfiguration.php

8 lines

Diff 40351

View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditEngine.php