Differential D16743

Fix Conpherence NUX showing empty Joinable Rooms
ClosedPublic
Actions

Authored by chad on Oct 20 2016, 11:53 PM.

Details

Reviewers

epriestley

Commits

rPfcff96f012c9: Fix Conpherence NUX showing empty Joinable Rooms

Summary

I moved this to setContent with the new search result layout, but failed to update NUX here.

Test Plan

Leave all rooms, get Joinable Rooms with list of 10 rooms.

Diff Detail

Repository

rP Phabricator

Branch

conpherence-nux (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14209
Build 18470: Run Core Tests
Build 18469: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40317.Oct 20 2016, 11:53 PM

chad retitled this revision from to Fix Conpherence NUX showing empty Joinable Rooms.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptOct 20 2016, 11:53 PM

epriestley accepted this revision.Oct 21 2016, 12:28 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 21 2016, 12:28 AM

Closed by commit rPfcff96f012c9: Fix Conpherence NUX showing empty Joinable Rooms (authored by chad, committed by chad). · Explain WhyOct 21 2016, 12:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

view/

ConpherenceLayoutView.php

8 lines

Diff 40317

View Options

src/applications/conpherence/view/ConpherenceLayoutView.php

Fix Conpherence NUX showing empty Joinable RoomsClosedPublicActions