Page MenuHomePhabricator
Differential D16736

Add developer UI for accessing NUX and "Overheated" query states
ClosedPublic
Actions

Authored by epriestley on Oct 20 2016, 4:11 PM.
Tags
None
Referenced Files
F14339544: D16736.diff
Wed, Dec 18, 6:49 PM
Unknown Object (File)
Sun, Dec 15, 5:50 PM
Unknown Object (File)
Sat, Dec 14, 12:39 PM
Unknown Object (File)
Thu, Dec 12, 10:36 PM
Unknown Object (File)
Tue, Dec 3, 1:23 PM
Unknown Object (File)
Tue, Dec 3, 7:10 AM
Unknown Object (File)
Mon, Dec 2, 12:27 AM
Unknown Object (File)
Thu, Nov 28, 4:10 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11773: Improve behaviors for "overheated" policy queries
Commits
rPc3644216bf22: Add developer UI for accessing NUX and "Overheated" query states
Summary

Ref T11773. Not committed to this implementation, but adds some "Developer" query actions to jump to the nux/overheated states without needing to know secret magic URL variables.

Test Plan

Screen Shot 2016-10-20 at 9.10.37 AM.png (178×303 px, 21 KB)

Diff Detail

Repository
rP Phabricator
Branch
query2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/search/controller/PhabricatorApplicationSearchController.php:291XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 14190
Build 18439: Run Core Tests
Build 18438: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40297.Oct 20 2016, 4:11 PM
epriestley retitled this revision from to Add developer UI for accessing NUX and "Overheated" query states.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11773: Improve behaviors for "overheated" policy queries.
epriestley added inline comments.Oct 20 2016, 4:12 PM
src/applications/search/controller/PhabricatorApplicationSearchController.php
572

Note that these only show up if developer mode is on, so normal users won't see them.

chad accepted this revision.Oct 20 2016, 7:45 PM
chad edited edge metadata.

seems weird but useful. not sure a better path

This revision is now accepted and ready to land.Oct 20 2016, 7:45 PM
epriestley added a comment.Oct 20 2016, 8:38 PM

Yeah, I like not having it not be 100% super secret magic that you have to read the source to figure out. We might be able to find a better place for it in the long run.

Closed by commit rPc3644216bf22: Add developer UI for accessing NUX and "Overheated" query states (authored by epriestley, committed by epriestley). · Explain WhyOct 20 2016, 8:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
search/
controller/
48 lines
engine/
4 lines

Diff 40297

View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
Phabricator · Built by Phacility