Ref T11773. This is an initial first step toward a more complete solution, but should make the worst case much less bad: prior to this change, the worst case was "30 second exeuction timeout". After this patch, the worst case is "no results + explanatory message", which is strictly better.
Details
Details
Made all feed stories fail policy checks, loaded home page.
- Before adding overheating: 9,600 queries / 20 seconds
- After adding overheating: 376 queries / 800ms
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- query1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 14188 Build 18435: Run Core Tests Build 18434: arc lint + arc unit
Event Timeline
Comment Actions
For clarity, only enforce the overheat limit if the query has a limit.
We can't currently reach the check without a limit, but this is a little easier to read and future-proofs us against reorganization of this code.