Page MenuHomePhabricator

Hide footer on mobile Conpherence
ClosedPublic

Authored by chad on Oct 19 2016, 10:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 10:25 AM
Unknown Object (File)
Sun, Nov 24, 4:00 PM
Unknown Object (File)
Sat, Nov 23, 3:33 AM
Unknown Object (File)
Thu, Nov 21, 3:34 PM
Unknown Object (File)
Sat, Nov 16, 9:03 PM
Unknown Object (File)
Thu, Nov 14, 8:01 PM
Unknown Object (File)
Thu, Nov 14, 7:59 AM
Unknown Object (File)
Wed, Nov 13, 1:41 AM
Subscribers

Details

Summary

This has been causing scrolling issues for me for a while, turns out the footer behind the Conpherence layout can bubble up and cause scrolling issues if you don't hit the scrollarea in the right place with your finger. Hiding it via CSS or removing the footer in the configuration resolves the issue on my phone on secure.

Test Plan

Test with and without footer on secure, hide footer in CSS since it's not visible anyways.

Diff Detail

Repository
rP Phabricator
Branch
conph-mobile-footer (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14184
Build 18428: Run Core Tests
Build 18427: arc lint + arc unit

Event Timeline

chad retitled this revision from to Hide footer on mobile Conpherence.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 19 2016, 10:17 PM
This revision was automatically updated to reflect the committed changes.