Page MenuHomePhabricator

Remove 'full-display' setting from Conpherence, spruce up search results
ClosedPublic

Authored by chad on Oct 15 2016, 7:35 PM.
Tags
None
Referenced Files
F14399561: D16710.diff
Sun, Dec 22, 5:15 PM
Unknown Object (File)
Sat, Dec 7, 7:07 AM
Unknown Object (File)
Fri, Dec 6, 3:38 AM
Unknown Object (File)
Thu, Dec 5, 8:01 AM
Unknown Object (File)
Sat, Nov 30, 1:39 PM
Unknown Object (File)
Fri, Nov 29, 5:06 PM
Unknown Object (File)
Wed, Nov 27, 5:55 AM
Unknown Object (File)
Sat, Nov 23, 3:34 PM
Subscribers

Details

Summary

This removes 'full-display', 'minimal-display' from Conpherence, which I recall was because we had 2 UIs for column and regular chat. I'm also tossing in slightly nicer search results, with a link to the actual message and the full date shown for context.

Test Plan

Post a message in mobile, tablet, full conpherence, and in durable column. Clean up UI in durable column. Do a search in Full UI, click on result date, get taken to the message... usually. My test data is a little wonky, but I think this works most of the time.

Diff Detail

Repository
rP Phabricator
Branch
conph-search-ui-4 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14130
Build 18346: Run Core Tests
Build 18345: arc lint + arc unit

Event Timeline

chad retitled this revision from to Remove 'full-display' setting from Conpherence transactions.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
  • minor css background fix
  • make search show full dates
  • js link to room result, hopefully scroll you there
chad retitled this revision from Remove 'full-display' setting from Conpherence transactions to Remove 'full-display' setting from Conpherence,, spruce up search results.Oct 16 2016, 3:30 AM
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad retitled this revision from Remove 'full-display' setting from Conpherence,, spruce up search results to Remove 'full-display' setting from Conpherence, spruce up search results.Oct 17 2016, 7:40 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 17 2016, 10:38 PM
This revision was automatically updated to reflect the committed changes.