Page MenuHomePhabricator
Differential D16708

New UI for fulltext message search
ClosedPublic
Actions

Authored by chad on Oct 14 2016, 7:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 25, 2:04 PM
Unknown Object (File)
Thu, Dec 19, 4:41 PM
Unknown Object (File)
Sat, Dec 14, 3:36 PM
Unknown Object (File)
Dec 9 2024, 3:34 PM
Unknown Object (File)
Dec 8 2024, 12:59 PM
Unknown Object (File)
Dec 6 2024, 7:28 AM
Unknown Object (File)
Dec 4 2024, 10:59 PM
Unknown Object (File)
Dec 3 2024, 7:15 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T3165: Provide Search in Conpherence
Commits
rP49165bc6d784: New UI for fulltext message search
Summary

Basically all here, but still probably needs some polish (links to jump? full dates?). Looks much better, still duplicates messages though sometimes. Needs to debug that more.

Test Plan

Revisit search UI inside Conpherence, outside Conpherence, and normal room searches in Conpherence.

Screen Shot 2016-10-14 at 12.11.28 PM.png (1×2 px, 343 KB)

Screen Shot 2016-10-14 at 12.11.21 PM.png (1×2 px, 477 KB)

Screen Shot 2016-10-14 at 12.11.16 PM.png (1×2 px, 389 KB)

Diff Detail

Repository
rP Phabricator
Branch
conph-search-ui-1 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14126
Build 18340: Run Core Tests
Build 18339: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40230.Oct 14 2016, 7:09 PM
chad retitled this revision from to New UI for fulltext message search.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 14 2016, 7:09 PM
chad edited the test plan for this revision. (Show Details)Oct 14 2016, 7:12 PM
chad updated this revision to Diff 40232.Oct 14 2016, 9:18 PM
  • fix for loop only showing 1 group result
chad updated this revision to Diff 40233.Oct 15 2016, 4:34 AM
  • fix double render with ajax.
epriestley accepted this revision.Oct 15 2016, 11:29 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 15 2016, 11:29 AM
Closed by commit rP49165bc6d784: New UI for fulltext message search (authored by chad, committed by chad). · Explain WhyOct 15 2016, 1:58 PM
This revision was automatically updated to reflect the committed changes.
chad added a task: T3165: Provide Search in Conpherence.Oct 15 2016, 2:42 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
conpherence/
controller/
2 lines
query/
119 lines
view/
17 lines
webroot/
rsrc/
css/
application/
conpherence/
86 lines
27 lines

Diff 40233

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceThreadSearchController.php

Loading...
View Options

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceTransactionView.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/message-pane.css

Loading...
View Options

webroot/rsrc/css/application/conpherence/transaction.css

Loading...
Phabricator · Built by Phacility