We currently fetch 15 transactions for 5 rooms, which leads to some room subtitles in the notification panel to being blank since nothing was fetched. I don't think this is a great fix, but moves the bar much further. Maybe there is a more accurate fix that isn't 5 SQL queries?
Details
Details
Review notification panel in sandbox, ensure all threads have some additional information.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- trans-limit (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 14083 Build 18271: Run Core Tests Build 18270: arc lint + arc unit
Event Timeline
Comment Actions
Yeah, this is garbage but fixing it isn't trivial. Best would probably be something like this:
- Put a nullable lastInterestingTransactionPHID (or whatever, that name is kind of wordy) on ConpherenceThread.
- When writing a transaction, update that field if it's an "interesting" transaction (I personally think only chat is interesting, but there's room for product debate on that).
- Get rid of needTransactions(), replace it with needLastInterestingTransactions().
- Do one query to load + attach those specific transactions by PHID.
