Differential D16684

Fix an issue with recurrence rules being set improperly in transaction code
ClosedPublic
Actions

Authored by epriestley on Oct 7 2016, 3:00 PM.

Details

Reviewers

chad

Maniphest Tasks

T11745: adding a new calendar event gives invalid cast exception

Commits

rP72edd36c7a06: Fix an issue with recurrence rules being set improperly in transaction code

Summary

Fixes T11745. I just missed this while juggling some of the internal storage.

Test Plan

Created a new event with recurrence behavior.

Diff Detail

Repository

rP Phabricator

Branch

cal1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14059
Build 18239: Run Core Tests
Build 18238: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40168.Oct 7 2016, 3:00 PM

epriestley retitled this revision from to Fix an issue with recurrence rules being set improperly in transaction code.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11745: adding a new calendar event gives invalid cast exception .

chad accepted this revision.Oct 7 2016, 3:05 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 7 2016, 3:05 PM

Closed by commit rP72edd36c7a06: Fix an issue with recurrence rules being set improperly in transaction code (authored by epriestley, committed by epriestley). · Explain WhyOct 7 2016, 3:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

xaction/

PhabricatorCalendarEventFrequencyTransaction.php

3 lines

Diff 40168

View Options

src/applications/calendar/xaction/PhabricatorCalendarEventFrequencyTransaction.php

Fix an issue with recurrence rules being set improperly in transaction codeClosedPublicActions