Differential D16671

Swap "Description" and "Invitees / Details" on Calendar event views
ClosedPublic
Actions

Authored by epriestley on Oct 5 2016, 6:35 PM.

Details

Reviewers

chad

Maniphest Tasks

T11326: Improve Calendar v1 Design/UI/UX

Commits

rPc5efa3ecb5d5: Swap "Description" and "Invitees / Details" on Calendar event views

Summary

Ref T11326. This reorders sections:

Description (if present)
Recurring event series info (if recurring)
Invitees (this also has custom stuff, if it exists)

Test Plan

Viewed some events, saw more sensible order.

Diff Detail

Repository

rP Phabricator

Branch

cal11

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14019
Build 18182: Run Core Tests
Build 18181: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40129.Oct 5 2016, 6:35 PM

epriestley retitled this revision from to Swap "Description" and "Invitees / Details" on Calendar event views.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11326: Improve Calendar v1 Design/UI/UX.

chad accepted this revision.Oct 5 2016, 8:32 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 5 2016, 8:32 PM

Closed by commit rPc5efa3ecb5d5: Swap "Description" and "Invitees / Details" on Calendar event views (authored by epriestley, committed by epriestley). · Explain WhyOct 6 2016, 11:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

controller/

PhabricatorCalendarEventViewController.php

4 lines

Diff 40129

View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Swap "Description" and "Invitees / Details" on Calendar event viewsClosedPublicActions