Unclear these are worth sending, but mostly seems useful. Returns getTitle for the transaction if it's not a message. Fixes T10683
Details
Details
Leave rooms, change names, add pictures.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- conph-participant (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 13990 Build 18134: Run Core Tests Build 18133: arc lint + arc unit
Event Timeline
Comment Actions
Personally, it seems weird that join/leave mark the room unread. I wouldn't expect title or picture changes to, either -- really, anything but a new message.
Regardless, you should be able to get a text rendering of the action like this, I think:
$text = id(clone $action_transaction) ->setRenderingTarget(PhabricatorApplicationTransaction::TARGET_TEXT) ->getTitle();
Try that instead of strip_tags()?