Page MenuHomePhabricator

Return more transaction types in Conpherence notification menu
ClosedPublic

Authored by chad on Oct 3 2016, 8:03 PM.
Tags
None
Referenced Files
F14057553: D16658.id40100.diff
Sun, Nov 17, 4:35 AM
F14052249: D16658.diff
Fri, Nov 15, 7:46 AM
F14038470: D16658.diff
Sun, Nov 10, 11:47 PM
F14024782: D16658.diff
Thu, Nov 7, 12:18 PM
F14006264: D16658.id.diff
Mon, Oct 28, 4:35 AM
F13995060: D16658.id40099.diff
Wed, Oct 23, 10:24 AM
F13993554: D16658.id40103.diff
Tue, Oct 22, 11:41 PM
F13993311: D16658.id40100.diff
Tue, Oct 22, 10:01 PM
Subscribers

Details

Summary

Unclear these are worth sending, but mostly seems useful. Returns getTitle for the transaction if it's not a message. Fixes T10683

Test Plan

Leave rooms, change names, add pictures.

Diff Detail

Repository
rP Phabricator
Branch
conph-participant (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13989
Build 18132: Run Core Tests
Build 18131: arc lint + arc unit

Event Timeline

chad retitled this revision from to Return more transaction types in Conpherence notification menu.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

Personally, it seems weird that join/leave mark the room unread. I wouldn't expect title or picture changes to, either -- really, anything but a new message.

Regardless, you should be able to get a text rendering of the action like this, I think:

$text = id(clone $action_transaction)
  ->setRenderingTarget(PhabricatorApplicationTransaction::TARGET_TEXT)
  ->getTitle();

Try that instead of strip_tags()?

This revision now requires changes to proceed.Oct 3 2016, 8:12 PM
chad edited edge metadata.
  • use a rendering target
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 3 2016, 9:26 PM
This revision was automatically updated to reflect the committed changes.