Page MenuHomePhabricator
Differential D16657

Clean up css race condition in Conpherence notification menu
ClosedPublic
Actions

Authored by chad on Oct 3 2016, 7:21 PM.
Tags
None
Referenced Files
F15483979: D16657.id40098.diff
Wed, Apr 9, 3:32 PM
F15483783: D16657.id40098.diff
Wed, Apr 9, 2:22 PM
F15483169: D16657.diff
Wed, Apr 9, 10:23 AM
F15482525: D16657.id40097.diff
Wed, Apr 9, 6:01 AM
F15480846: D16657.diff
Tue, Apr 8, 4:55 PM
F15480786: D16657.diff
Tue, Apr 8, 4:27 PM
F15452937: D16657.id.diff
Sat, Mar 29, 8:16 AM
F15445626: D16657.diff
Thu, Mar 27, 3:04 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP3ce3ce957d3f: Clean up css race condition in Conpherence notification menu
Summary

Depending on when packages loaded, this CSS sometimes gets overwritten. Make it more specific and always present.

Test Plan

Reload a lot

Diff Detail

Repository
rP Phabricator
Branch
conph-menu (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13987
Build 18129: Run Core Tests
Build 18128: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40097.Oct 3 2016, 7:21 PM
chad retitled this revision from to Clean up css race condition in Conpherence notification menu.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 3 2016, 7:21 PM
epriestley accepted this revision.Oct 3 2016, 7:29 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 3 2016, 7:29 PM
Closed by commit rP3ce3ce957d3f: Clean up css race condition in Conpherence notification menu (authored by chad, committed by chad). · Explain WhyOct 3 2016, 7:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
conpherence/
controller/
2 lines
webroot/
rsrc/
css/
application/
conpherence/
3 lines

Diff 40097

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceNotificationPanelController.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/notification.css

Loading...
Phabricator · Built by Phacility