Hide extra rooms when you have too many in Conpherence
ClosedPublic
Actions

Authored by chad on Oct 3 2016, 6:13 PM.

Details

Reviewers

Commits

rPe828e7f8898b: Hide extra rooms when you have too many in Conpherence

Summary

This probably stopped working when we switch to a standard nav view. Re-scope CSS. Also make scrolling to last room a little easier.

Test Plan

Make 20 rooms, see the old ones vanish. Click See More, scroll to bottom, click last room

Diff Detail

Repository

rP Phabricator

Branch

thread-list (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13984
Build 18124: Run Core Tests
Build 18123: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40094.Oct 3 2016, 6:13 PM

chad retitled this revision from to Hide extra rooms when you have too many in Conpherence.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptOct 3 2016, 6:13 PM

(The whole "click to show a few more sort of arbitrarily" has always felt weird to me, FWIW.)

This revision is now accepted and ready to land.Oct 3 2016, 9:28 PM

I think we'll need it if we separate rooms by type (public, private, direct).

Closed by commit rPe828e7f8898b: Hide extra rooms when you have too many in Conpherence (authored by chad, committed by chad). · Explain WhyOct 3 2016, 9:32 PM

This revision was automatically updated to reflect the committed changes.

at least, if we end up with a single list, I'd agree with you and remove it

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

application/

conpherence/

menu.css

6 lines

Diff 40094

View Options

resources/celerity/map.php