Page MenuHomePhabricator
Differential D16655

Clean up nux state with durable column
ClosedPublic
Actions

Authored by chad on Oct 3 2016, 5:29 PM.
Tags
None
Referenced Files
F15184969: D16655.diff
Thu, Feb 20, 8:44 PM
Unknown Object (File)
Tue, Feb 18, 11:50 AM
Unknown Object (File)
Sun, Feb 9, 2:31 AM
Unknown Object (File)
Sun, Feb 9, 2:31 AM
Unknown Object (File)
Sun, Feb 9, 2:31 AM
Unknown Object (File)
Sun, Feb 9, 2:31 AM
Unknown Object (File)
Fri, Jan 24, 4:43 PM
Unknown Object (File)
Fri, Jan 24, 4:43 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP1d00bc918019: Clean up nux state with durable column
Summary

Remove policy icons from durable column, create a basic nux layout and style.

Test Plan

leave all rooms, pop open chat, see helpful text and button.

Diff Detail

Repository
rP Phabricator
Branch
column-nux (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13983
Build 18122: Run Core Tests
Build 18121: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40092.Oct 3 2016, 5:29 PM
chad retitled this revision from to Clean up nux state with durable column.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 3 2016, 5:29 PM
chad updated this revision to Diff 40093.Oct 3 2016, 5:33 PM
  • also remove policy icon css
epriestley accepted this revision.Oct 3 2016, 5:49 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 3 2016, 5:49 PM
Closed by commit rP1d00bc918019: Clean up nux state with durable column (authored by chad, committed by chad). · Explain WhyOct 3 2016, 6:30 PM
This revision was automatically updated to reflect the committed changes.
ralph.van.etten mentioned this in T11784: Differential "stick to the comment area" and "jump to anchor" scroll behaviors interact destructively while loading content.Oct 25 2016, 6:57 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
conpherence/
view/
53 lines
webroot/
rsrc/
css/
application/
conpherence/
21 lines

Diff 40093

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceDurableColumnView.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/durable-column.css

Loading...
Phabricator · Built by Phacility