Always reset scroll after durable column is maximized
ClosedPublic
Actions

Authored by chad on Oct 3 2016, 2:42 AM.

Details

Reviewers

Commits

rP55a56c09e7fd: Always reset scroll after durable column is maximized

Summary

When the durable column is re-opened, scroll user to latest message. Though later we should scroll them to the last read.

Test Plan

Minimize window, reload page, pop up window, see proper scroll position.

Diff Detail

Repository

rP Phabricator

Branch

scroll-conph (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13973
Build 18106: Run Core Tests
Build 18105: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40082.Oct 3 2016, 2:42 AM

chad retitled this revision from to Always reset scroll after durable column is maximized.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptOct 3 2016, 2:42 AM

epriestley accepted this revision.Oct 3 2016, 3:29 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 3 2016, 3:29 AM

Closed by commit rP55a56c09e7fd: Always reset scroll after durable column is maximized (authored by chad, committed by chad). · Explain WhyOct 3 2016, 3:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

26 lines

webroot/

rsrc/

js/

application/

conpherence/

behavior-durable-column.js

5 lines

Diff 40082

View Options

resources/celerity/map.php