Page MenuHomePhabricator
Differential D16583

Truncate and scroll task graph tables instead of fitting task titles to the display
ClosedPublic
Actions

Authored by epriestley on Sep 21 2016, 9:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 2, 4:54 AM
Unknown Object (File)
Thu, Jan 30, 7:54 PM
Unknown Object (File)
Tue, Jan 21, 7:03 PM
Unknown Object (File)
Tue, Jan 21, 3:23 PM
Unknown Object (File)
Tue, Jan 21, 3:27 AM
Unknown Object (File)
Sun, Jan 19, 5:57 PM
Unknown Object (File)
Dec 15 2024, 6:40 PM
Unknown Object (File)
Dec 12 2024, 8:55 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11676: For task with many dependencies, cannot scroll horizontally in Task Graph for certain widths (overflow is clipped)
Commits
rP66c7f22c273c: Truncate and scroll task graph tables instead of fitting task titles to the…
Summary

Fixes T11676. Instead of trying to fit task titles to the display, truncate them and let the table scroll.

Test Plan

Table now scrolls when cramped:

Screen Shot 2016-09-21 at 2.41.42 PM.png (217×564 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Branch
scroll1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13799
Build 17833: Run Core Tests
Build 17832: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39912.Sep 21 2016, 9:45 PM
epriestley retitled this revision from to Truncate and scroll task graph tables instead of fitting task titles to the display.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11676: For task with many dependencies, cannot scroll horizontally in Task Graph for certain widths (overflow is clipped).
Herald edited edge metadata. · View Herald TranscriptSep 21 2016, 9:45 PM
chad accepted this revision.Sep 22 2016, 12:55 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 22 2016, 12:55 AM
Closed by commit rP66c7f22c273c: Truncate and scroll task graph tables instead of fitting task titles to the… (authored by epriestley, committed by epriestley). · Explain WhySep 22 2016, 1:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
infrastructure/
graph/
11 lines
webroot/
rsrc/
css/
aphront/
4 lines

Diff 39912

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/graph/ManiphestTaskGraph.php

Loading...
View Options

webroot/rsrc/css/aphront/table-view.css

Loading...
Phabricator · Built by Phacility