Differential D16577

Support persistent connections in libphutil
ClosedPublic
Actions

Authored by epriestley on Sep 20 2016, 2:29 PM.

Details

Reviewers

chad

Maniphest Tasks

T11672: Evaluate persistent connections from HTTP contexts

Commits

rPHU2663da19a0ee: Support persistent connections in libphutil

Summary

Ref T11672. This adds a flag to opt in to persistent connections.

Test Plan

See next change.

Diff Detail

Repository

rPHU libphutil

Branch

pconnect1

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php:95	XHP45	PHP Compatibility
Error	src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php:176	XHP45	PHP Compatibility

Unit

Tests Passed

Build Status

Buildable 13788
Build 17812: Run Core Tests
Build 17811: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39902.Sep 20 2016, 2:29 PM

epriestley retitled this revision from to Support persistent connections in libphutil.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11672: Evaluate persistent connections from HTTP contexts.

epriestley added a child revision: D16578: Use persistent database connections from web contexts.Sep 20 2016, 2:34 PM

chad accepted this revision.Sep 20 2016, 2:43 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 20 2016, 2:43 PM

Closed by commit rPHU2663da19a0ee: Support persistent connections in libphutil (authored by epriestley, committed by epriestley). · Explain WhySep 21 2016, 9:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

aphront/

storage/

connection/

AphrontDatabaseConnection.php

16 lines

mysql/

AphrontMySQLiDatabaseConnection.php

4 lines

Diff 39902

View Options

src/aphront/storage/connection/AphrontDatabaseConnection.php