Page MenuHomePhabricator
Differential D16567

Remove TYPE_FILES from Conpherence
ClosedPublic
Actions

Authored by chad on Sep 17 2016, 5:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
May 27 2025, 11:30 AM
Unknown Object (File)
May 7 2025, 5:31 PM
Unknown Object (File)
May 7 2025, 5:37 AM
Unknown Object (File)
Apr 30 2025, 6:38 AM
Unknown Object (File)
Apr 26 2025, 11:08 PM
Unknown Object (File)
Apr 25 2025, 8:26 PM
Unknown Object (File)
Apr 12 2025, 5:16 PM
Unknown Object (File)
Apr 11 2025, 3:45 AM
View All Files
Subscribers
Korvin
Tokens
"Evil Spooky Haunted Tree" token, awarded by epriestley.

Details

Reviewers
epriestley
Commits
rPa2a19e29aace: Remove TYPE_FILES from Conpherence
Summary

I believe these are left over from widgets, when we added a "Files" widget that kept track of everything added to the window.

Test Plan

Added files to a Conpherece, Set an image when editing. Anything else?

Diff Detail

Repository
rP Phabricator
Branch
conph-files (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13754
Build 17763: Run Core Tests
Build 17762: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39877.Sep 17 2016, 5:57 AM
chad retitled this revision from to Remove TYPE_FILES from Conpherence.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 17 2016, 5:57 AM
epriestley accepted this revision.Sep 17 2016, 9:02 PM
epriestley edited edge metadata.

Nice!

This revision is now accepted and ready to land.Sep 17 2016, 9:02 PM
epriestley awarded a token.Sep 17 2016, 9:02 PM
Closed by commit rPa2a19e29aace: Remove TYPE_FILES from Conpherence (authored by chad, committed by chad). · Explain WhySep 17 2016, 9:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39877

View Options

src/applications/conpherence/__tests__/ConpherenceRoomTestCase.php

Loading...
View Options

src/applications/conpherence/conduit/ConpherenceQueryThreadConduitAPIMethod.php

Loading...
View Options

src/applications/conpherence/conduit/ConpherenceUpdateThreadConduitAPIMethod.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...
View Options

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...
View Options

src/applications/conpherence/query/ConpherenceThreadQuery.php

Loading...
View Options

src/applications/conpherence/storage/ConpherenceThread.php

Loading...
View Options

src/applications/conpherence/storage/ConpherenceTransaction.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceTransactionView.php

Loading...
Phabricator · Built by Phacility