Page MenuHomePhabricator
Differential D16560

Rebuild Conpherence Participants Pane
ClosedPublic
Actions

Authored by chad on Sep 15 2016, 7:57 PM.
Tags
None
Referenced Files
F15390046: D16560.id.diff
Sat, Mar 15, 5:52 AM
F15389713: D16560.id.diff
Sat, Mar 15, 5:35 AM
F15374204: D16560.diff
Wed, Mar 12, 5:41 PM
Unknown Object (File)
Feb 20 2025, 11:10 PM
Unknown Object (File)
Feb 20 2025, 9:34 PM
Unknown Object (File)
Feb 20 2025, 9:33 PM
Unknown Object (File)
Feb 20 2025, 9:33 PM
Unknown Object (File)
Feb 20 2025, 8:14 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPf6023d17da81: Rebuild Conpherence Participants Pane
Summary

Mostly quality of life in renames and moving everything to the view class. Minor CSS tweaks. Fix room handles getting added when adding a new user.

Test Plan

Add to room, remove from room.

Diff Detail

Repository
rP Phabricator
Branch
participant-pane (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13735
Build 17730: Run Core Tests
Build 17729: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39856.Sep 15 2016, 7:57 PM
chad retitled this revision from to Rebuild Conpherence Participants Pane.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 15 2016, 7:57 PM
epriestley accepted this revision.Sep 15 2016, 8:16 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/conpherence/view/ConpherenceParticipantView.php
93

Prefer %s with PhutilNumber so 1,234 is formatted in a nice locale-aware way with a comma or other separator.

This revision is now accepted and ready to land.Sep 15 2016, 8:16 PM
Closed by commit rPf6023d17da81: Rebuild Conpherence Participants Pane (authored by chad, committed by chad). · Explain WhySep 15 2016, 8:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
72 lines
4 lines
src/
applications/
conpherence/
controller/
49 lines
view/
10 lines
46 lines
webroot/
rsrc/
css/
application/
conpherence/
participant-pane.css
widget-pane.css
55 lines
core/
2 lines
js/
application/
conpherence/
2 lines
behavior-participant-pane.js
behavior-participants-pane.js
4 lines

Diff 39856

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceParticipantController.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceLayoutView.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceParticipantView.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/participant-pane.css

Loading...
View Options

webroot/rsrc/css/application/conpherence/widget-pane.css

Loading...
View Options

webroot/rsrc/css/core/z-index.css

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-menu.js

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-participant-pane.js

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-participants-pane.js

Loading...
Phabricator · Built by Phacility